add: fee to output #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xB10C
force-pushed
the
2024-03-add-fee-to-output
branch
from
26a8cec to
bf12f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calling
get_raw_transaction_info_with_feeslows things considerably down, having the tx fees is quite useful.An alternative would be to call the
getblock hash 2verbosity RPC to get the fees in the same msg as the block from Bitcoin Core. This is currently not implemented in rust-bitcoincore-rpc.but proposed in rust-bitcoin/rust-bitcoincore-rpc#329