Write captures under CAPTURE_DIR (default /tmp) instead of the working directory - #22
Open
turner-moore wants to merge 1 commit into
Open
Write captures under CAPTURE_DIR (default /tmp) instead of the working directory#22turner-moore wants to merge 1 commit into
turner-moore wants to merge 1 commit into
Conversation
The four capture tools hardcoded the temp file as 'temp_capture.pcap' in the process working directory. That fails when the cwd is read-only, clutters the working directory, and risks collisions between concurrent captures. Route the temp pcap through a CAPTURE_DIR env var, defaulting to /tmp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All four capture tools (
capture_packets,capture_summary,capture_conversations, and the threat-check capture) hardcode the temp file astemp_capture.pcapin the process's current working directory:Writing into the cwd has three downsides:
Fix
Route the temp pcap through a
CAPTURE_DIRenvironment variable, defaulting to/tmp(the conventional place for scratch files):Compatibility
Behavior changes only in that the scratch file now lands in
/tmpby default instead of the cwd. The file is temporary and deleted after processing, so nothing downstream depends on its location. Anyone who wants the old location can setCAPTURE_DIR=..