fix(core): correct bound_into_included_u64 handling for excluded start bounds - #3589
Open
yappermoar-boop wants to merge 1 commit into
Open
Conversation
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
huitseeker
reviewed
Aug 14, 2026
| } | ||
|
|
||
| #[test] | ||
| fn test_bound_into_included_u64() { |
Collaborator
There was a problem hiding this comment.
At u64::MAX, the new addition saturates back to u64::MAX, so an excluded start becomes a range containing that value instead of an empty range. Excluding 0 as an end has the same problem. Could this return Option or Result to represent these empty bounds and cover both endpoints here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated bound_into_included_u64 in core/src/utils/mod.rs to correctly perform saturating_add(1) when handling an Excluded start bound (is_start == true). Previously, saturating_sub(1) was executed regardless of is_start, producing incorrect lower bounds. Added unit tests to verify behavior for all Bound variants.