refactor: separate precompile verification from proving - #3734
Merged
Conversation
Al-Kindi-0
approved these changes
Aug 28, 2026
Al-Kindi-0
left a comment
Contributor
There was a problem hiding this comment.
Looks good, modulo the change log entry
bobbinth
reviewed
Aug 30, 2026
Comment on lines
38
to
42
| "crates/precompiles", | ||
| "crates/precompiles-air", | ||
| "crates/precompiles-verifier", | ||
| "crates/lib/core/codegen", | ||
| "crates/precompiles-prover", |
Contributor
There was a problem hiding this comment.
We'll need to set up trusted publishing for precompiles-air and precompiles-verifier crates.
Also question: is the reason crates/lib/core/codegen mixed in between the precompiles crates because it is related to precompiles?
Also also, after this PR, may be a good time to update the Project structure section in the main README as it has become quite outdated.
Collaborator
Author
There was a problem hiding this comment.
- The current position of
crates/lib/core/codegenis historical: it used to beprecompiles/codegen, and I will move it next tocrates/lib/core. - For miden-precompiles-air and miden-precompiles-verifier, recall you need to publish one version of each with an API token. Then you just need to add a trusted publisher for repository 0xMiden/miden-vm and workflow workspace-publish.yml, using the release environment.
huitseeker
force-pushed
the
feat/precompiles-verifier-split-incremental
branch
from
August 31, 2026 15:01
c4716bd to
a20f524
Compare
huitseeker
force-pushed
the
feat/precompiles-verifier-split-incremental
branch
from
August 31, 2026 15:14
a20f524 to
317b2b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miden-verifiernow usesmiden-precompiles-verifier. Shared AIR code is inmiden-precompiles-air.miden-precompiles-prover: verifier users do not build prover code.This completes the crate split discussed in #2282. #3222 created the runtime crate. #3293 and #3343 added the first PVM proof path. #3467 added the MASM verifier input adapter. #3672 settled the MASM package layout. The verifier split was left until that work was complete.
Closes #2282