Add missing row separators to KaTeX cases blocks - #3751
Closed
Bornoz wants to merge 1 commit into
Closed
Conversation
Every \begin{cases} block in the instruction-reference docs was missing the \\ row separator between its rows. remark-math + rehype-katex (per docs/docusaurus.config.ts) needs \\ to separate rows inside cases; without it KaTeX collapses the two rows into one, so a piecewise definition rendered as a single garbled line.
Added the separator to all 47 affected blocks across the four assembly instruction-reference files and stack_ops.md. Each block was checked by rendering it through KaTeX and confirming the row count matches the number of cases (one <mtr> per case); before the fix every one collapsed to a single row.
(design/chiplets/ace.md has two more cases blocks inside a blockquote with a different multi-row structure; left out of this change to keep it mechanical and reviewable.)
Closes 0xMiden#3650
|
This pull request was closed without review because none of the linked open issues Our contribution guidelines require contributions to link to an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
\begin{cases}block in the instruction-reference docs was missing the\\row separator between its rows.remark-math+rehype-katex(perdocs/docusaurus.config.ts) needs\\to separate rows insidecases; without it KaTeX collapses the rows into one and a piecewise definition renders as a single garbled line.Added the separator to all 47 affected blocks across the four assembly instruction-reference files and
stack_ops.md. Each block was verified by rendering it through KaTeX and confirming the row count (<mtr>per case) matches the number of cases — before the fix every one collapsed to a single row.design/chiplets/ace.mdhas two morecasesblocks inside a blockquote with a different structure; left out to keep this change mechanical and reviewable.Closes #3650