refactor: move component definitions to project files - #3587
Open
TomasArrachea wants to merge 10 commits into
Open
refactor: move component definitions to project files#3587TomasArrachea wants to merge 10 commits into
TomasArrachea wants to merge 10 commits into
Conversation
TomasArrachea
force-pushed
the
tomasarrachea-schema-definitions
branch
from
August 14, 2026 15:45
2fac64d to
ab49797
Compare
TomasArrachea
marked this pull request as ready for review
August 14, 2026 15:49
bobbinth
reviewed
Aug 14, 2026
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I left a few comments, but nothing major.
Not for this PR, but in general for the component metadata we could type most of the slots in a better way. We use word in many places where we could describe values more accurately.
mmagician
reviewed
Aug 24, 2026
| miden-standards.workspace = true | ||
|
|
||
| [package.metadata.account-component] | ||
| description = "Basic wallet component for receiving and sending assets" |
TomasArrachea
force-pushed
the
tomasarrachea-schema-definitions
branch
from
August 25, 2026 19:35
21666a4 to
1f50338
Compare
TomasArrachea
changed the title
TomasArrachea
force-pushed
the
tomasarrachea-schema-definitions
branch
from
August 26, 2026 21:29
4bbecd5 to
53e5e0b
Compare
Collaborator
Author
|
@PhilippGackstatter I pushed 53e5e0b with changes to address https://github.com/0xMiden/protocol/pull/3648/changes#r3863463417. The TokenPolicyManager now declares the asset-callback slots in its schema and they get filtered on component build depending on the configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3191.
This PR moves every account component's metadata (name, description, version and storage schema) from Rust into a
[package.metadata.account-component]table in itsmiden-project.toml. Now, the crates' build scripts interpret these manifest entries and embeds the metadata into the package.