fix(standards): bound the PSWAP lineage depth to u32 - #3777
Open
onurinanc wants to merge 7 commits into
Open
Conversation
# Conflicts: # crates/miden-standards/asm/standards/notes/pswap.masm # crates/miden-testing/tests/scripts/pswap.rs
mmagician
approved these changes
Sep 1, 2026
mmagician
left a comment
mmagician
left a comment
Collaborator
There was a problem hiding this comment.
MASM change is ok, but I'd reword some of the comments to be more human-readable
Comment on lines
+632
to
+633
| /// Returns an error if `attachment` was not stamped in a round after this note, or if the | ||
| /// fill amount is not a valid asset amount. |
Collaborator
There was a problem hiding this comment.
attachmentwas not stamped in a round after this note
I don't understand what this means, could we simplify?
Comment on lines
+639
to
+640
| // The payback of a round is derived from the note consumed in that round, whose serial | ||
| // sits one bump per preceding round after this note's. |
Collaborator
There was a problem hiding this comment.
serial sits one bump per preceding round after this note's.
Again, this reads cryptic to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_current_depthto au32, aborting withERR_PSWAP_PARENT_DEPTH_NOT_U32orERR_PSWAP_DEPTH_OVERFLOWinstead of wrapping the field.PswapAttachmentword through a newTryFrom<&NoteAttachment> for PswapNoteAttachmentwhenever aPswapNoteis built or decoded.Closes #3682.