Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FpMul is the first in a family of BigNum templates which do arithmetic over Fp but allow for aliased results, avoiding the (expensive) BigLess check that residues are less than the modulus. FpMul is a merged multiply and mod, which accumulates overflows and only computes range checks when reducing. Other potentially useful operations include FpAdd, FpSub, FpInv, FpMulAdd, etc; each has slightly different overflow bit lengths, so care should be taken when implementing. Additionally BigMultModP can be implemented as FpMul followed by a BigLess check.
Also simplify some generic bigint witness computation.