Skip to content

Commit 70de3cd

Browse files
committed
link issues in todos
1 parent 837d4f3 commit 70de3cd

File tree

5 files changed

+8
-2
lines changed

5 files changed

+8
-2
lines changed

src/backends/plonky2/circuits/mainpod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,6 +1222,7 @@ impl MainPodVerifyGadget {
12221222
let vds_root = builder.add_virtual_hash();
12231223
// TODO: verify that all input pod proofs use verifier data from the public input VD array
12241224
// This requires merkle proofs
1225+
// https://github.com/0xPARC/pod2/issues/250
12251226

12261227
// Verify that VD array that input pod uses is the same we use now.
12271228
for verified_proof in verified_proofs {

src/backends/plonky2/mainpod/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ pub(crate) fn layout_statements(
258258

259259
// Input signed pods region
260260
// TODO: Replace this with a dumb signed pod
261+
// https://github.com/0xPARC/pod2/issues/246
261262
let none_sig_pod_box: Box<dyn Pod> = Box::new(NonePod {});
262263
let none_sig_pod = none_sig_pod_box.as_ref();
263264
assert!(inputs.signed_pods.len() <= params.max_input_signed_pods);
@@ -548,6 +549,7 @@ pub struct MainPod {
548549
// generate it on-demand.
549550
fn get_common_data(params: &Params) -> Result<CommonCircuitData<F, D>, Error> {
550551
// TODO: Cache this somehow
552+
// https://github.com/0xPARC/pod2/issues/247
551553
let rec_params = recursion::new_params::<MainPodVerifyTarget>(
552554
params.max_input_recursive_pods,
553555
NUM_PUBLIC_INPUTS,
@@ -567,6 +569,7 @@ impl MainPod {
567569
// 1, 3, 4, 5 verification via the zkSNARK proof
568570
let rec_circuit_data = &*STANDARD_REC_MAIN_POD_CIRCUIT_DATA;
569571
// TODO: cache these artefacts
572+
// https://github.com/0xPARC/pod2/issues/247
570573
let (_, circuit_data) = RecursiveCircuit::<MainPodVerifyTarget>::circuit_data_padded(
571574
self.params.max_input_recursive_pods,
572575
&rec_circuit_data.common,

src/backends/plonky2/recursion/circuit.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,7 @@ pub fn pad_circuit(builder: &mut CircuitBuilder<F, D>, common_data: &CommonCircu
420420
assert_eq!(common_data.config, builder.config);
421421
assert_eq!(common_data.num_public_inputs, builder.num_public_inputs());
422422
// TODO: We need to figure this out once we enable zero-knowledge
423+
// https://github.com/0xPARC/pod2/issues/248
423424
assert!(
424425
!common_data.config.zero_knowledge,
425426
"Degree calculation can be off if zero-knowledge is on."

src/frontend/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ impl MainPodBuilder {
562562
statements: &statements,
563563
operations: &operations,
564564
public_statements: &public_statements,
565-
vds_root: EMPTY_HASH, // TODO
565+
vds_root: EMPTY_HASH, // TODO https://github.com/0xPARC/pod2/issues/249
566566
};
567567
let pod = prover.prove(&self.params, inputs)?;
568568

src/middleware/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -782,6 +782,7 @@ pub trait PodSigner {
782782
}
783783

784784
// TODO: Delete once we have a fully working EmptyPod and a dumb SignedPod
785+
// https://github.com/0xPARC/pod2/issues/246
785786
/// This is a filler type that fulfills the Pod trait and always verifies. It's empty. This
786787
/// can be used to simulate padding in a circuit.
787788
#[derive(Debug, Clone)]
@@ -814,7 +815,7 @@ pub struct MainPodInputs<'a> {
814815
/// Statements that need to be made public (they can come from input pods or input
815816
/// statements)
816817
pub public_statements: &'a [Statement],
817-
pub vds_root: Hash, // TODO: Figure out if we use Hash or a Map here
818+
pub vds_root: Hash, // TODO: Figure out if we use Hash or a Map here https://github.com/0xPARC/pod2/issues/249
818819
}
819820

820821
pub trait PodProver {

0 commit comments

Comments
 (0)