chore(backend): implement more circuit op logic#173
Merged
ax0 merged 8 commits into0xPARC:mainfrom Apr 7, 2025
Merged
Conversation
ed255
approved these changes
Apr 4, 2025
Collaborator
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM!
I left a few minor suggestions
| // of the provided Merkle proofs (if any). These proofs have already | ||
| // been verified, so we need only look up the claim. | ||
| let resolved_merkle_claim = | ||
| (merkle_claims.len() > 0).then(|| builder.vec_ref(merkle_claims, op.aux[0])); |
Collaborator
There was a problem hiding this comment.
Will merkle_claims.len() ever be 0?
If that's not the case, this could be simplified.
src/backends/plonky2/mainpod.rs
Outdated
| params, | ||
| &statements, | ||
| &[], // TODO: fill in the merkle proofs for Contains/NotContains ops | ||
| &merkle_proofs, // TODO: fill in the merkle proofs for Contains/NotContains ops |
| impl TryFrom<MerkleClaimAndProof> for merkletree::MerkleProof { | ||
| type Error = anyhow::Error; | ||
| fn try_from(mp: MerkleClaimAndProof) -> Result<Self> { | ||
| match mp.enabled { |
Collaborator
There was a problem hiding this comment.
A suggestion to avoid too much nesting is to follow this pattern:
if bad_condition {
return Error;
}
// Proceed with the happy flow
arnaucube
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #156.