adjust recursive calculation using standard gates#251
Merged
Conversation
arnaucube
approved these changes
May 30, 2025
Collaborator
arnaucube
left a comment
There was a problem hiding this comment.
LGTM, will need to check if we would need to add a way to define extra custom gates for cases like the ecdsa introduction gadget
Collaborator
Author
We definitely need to add the custom gates defined in #236 to the list and redo the linear regression to get accurate values. For this reason I'll leave this PR unmerged until #236 is merged so that I can adjust it :) |
c91e4a6 to
c232e1b
Compare
5c548d7 to
1be5954
Compare
1be5954 to
0c5738b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the measure of verification cost was done on a circuit with just the NoopGate, but every time we add a gate to the set the verifier needs to perform the corresponding evaluation, so more gates add a constant overhead.
Now the measure is done with the same set of gates we use to define the recursively verifiable circuit.
With this we get a much better estimation and reduce the accuracy error of the linear regression to 2% (from 8%)
The overhead between verifying any proof with just the
NoopGateand verifying a proof with all these standard gates is about 400 num_gates (rows), no matter the circuit size.This needs to be updated once we add the gates from #236
Blocked by #236
I've extended the PR to:
resolve #253