Implement generic serialization/deserialization#260
Merged
Conversation
a239bfe to
f60d8f3
Compare
f60d8f3 to
0167872
Compare
f164914 to
681c1f6
Compare
robknight
reviewed
Jun 9, 2025
Collaborator
robknight
left a comment
There was a problem hiding this comment.
lgtm! I think it would be worth aligning the name of kvs and dict but otherwise all looks good.
ed255
commented
Jun 9, 2025
robknight
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podtrait to allow full serialization of any pod as a trait object so that serialization is fully generic.register_pod_deserializerMainPodandMockMainPodpub_self_statementsmethod to return the non-padded list of statements so that they match with the data that thePodBuildergenerates. This way we can skip some data processing in serialization/deserialization.Resolve #258