Better Hash and PartialEq for Keys and AnchoredKeys#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the original serialization code, I added the Hash and PartialEq traits to
AnchoredKeyandKey. The default implementation hashes both thehashandnamefields ofKeytogether, which is unnecessary - we can hash just thehashfield instead. Similarly, PartialEq does not need to compare both fields, it can compare just the hash field. This mirrors how the same traits were implemented for theValuetype.This should make storing Keys/AnchoredKeys in hashmaps/sets slightly more efficient.