Merged
Conversation
ed255
force-pushed
the
feat/no-unnecessary-mut
branch
from
877d979 to
b75059b
Compare
The PodSigner trait was taking `&mut self` in the `sign` method, but the signer doesn't need mutation in the Shcnorr implementation. Remove the `mut`. Previously the PodProver trait was also taking `&mut self` in the `prove` method, and we had many tests creating a `mut Prover/mut MockProver`. Remove all those `mut`. Breaking change: `PodSigner` trait method `sign` replaces `&mut self` by `&self`
ed255
force-pushed
the
feat/no-unnecessary-mut
branch
from
b75059b to
6959335
Compare
arnaucube
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PodSigner trait was taking
&mut selfin thesignmethod, but thesigner doesn't need mutation in the Shcnorr implementation. Remove the
mut.Previously the PodProver trait was also taking
&mut selfin theprovemethod, and we had many tests creating amut Prover/mut MockProver. Remove all thosemut.Breaking change:
PodSignertrait methodsignreplaces&mut selfby&selfBuilt on top of #339