Conversation
ed255
force-pushed
the
next/2026-02-06
branch
from
8674ae4 to
dae3911
Compare
robknight
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MainPodBuilder inserts implicit contains statements when operations take entries as arguments; but the MultiPodBuilder doesn't record those (operation, statement) pair. I've done a dirty hack to quickly resolve this issue; but we should discuss whether we merge this dirty hack, think of an alternative solution that is still simple, plan a merge of the MultiPodBuilder with the MainPodBuilder, etc.My solution was incorrect because the solver already considers deduplication. This was solved in MultiPodBuilder fixes #480