Share output-statement checks across native operations - #531
Open
robknight wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each native-operation checker previously rebuilt an expected output statement and compared it independently, even though the argument checks were derived from the same cached inputs. This duplicated a significant number of constraints across the
MainPodcircuit.During input resolution,
StatementCacherepresents each operation argument as a normalized equation pairing the statement argument that identifies the input with the concrete value used by the operation. For a referenced container entry, for example, this is roughlyanchored_key(origin, key) = entry_value; the left-hand side is what must appear in the output statement.This change precomputes whether each output argument matches those left-hand sides and whether the remaining arguments are correctly padded with
None.Individual operation checkers now only verify the predicate and select the shared argument check for that predicate's arity.This reduces the total gate count by 6,282 gates.