Merge pull request #30 from 0xPolygon/feat/informational

Fix/informational

src/DefaultEmissionManager.sol

@@ -29,6 +29,7 @@ contract DefaultEmissionManager is Ownable2StepUpgradeable, IDefaultEmissionMana
     uint256 public startTimestamp;
 
     constructor(address migration_, address stakeManager_, address treasury_) {
+        if (migration_ == address(0) || stakeManager_ == address(0) || treasury_ == address(0)) revert InvalidAddress();
         DEPLOYER = msg.sender;
         migration = IPolygonMigration(migration_);
         stakeManager = stakeManager_;

src/PolygonEcosystemToken.sol

@@ -73,6 +73,14 @@ contract PolygonEcosystemToken is ERC20Permit, AccessControlEnumerable, IPolygon
         return super.allowance(owner, spender);
     }
 
+    /// @notice Returns the implementation version
+    /// @dev This is to support our dev pipeline, and is present despite
+    /// this contract not being behind a proxy
+    /// @return Version string
+    function getVersion() external pure returns (string memory) {
+        return "1.0.0";
+    }
+
     function _updatePermit2Allowance(bool enabled) private {
         emit Permit2AllowanceUpdated(enabled);
         permit2Enabled = enabled;

src/PolygonMigration.sol

@@ -26,6 +26,7 @@ contract PolygonMigration is Ownable2StepUpgradeable, IPolygonMigration {
     }
 
     constructor(address matic_) {
+        if (matic_ == address(0)) revert InvalidAddress();
         matic = IERC20(matic_);
         // so that the implementation contract cannot be initialized
         _disableInitializers();

src/interfaces/IDefaultEmissionManager.sol

@@ -1,13 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.21;
 
+import {IPolygonEcosystemToken} from "./IPolygonEcosystemToken.sol";
+
 interface IDefaultEmissionManager {
     error InvalidAddress();
 
     event TokenMint(uint256 amount, address caller);
 
     function getVersion() external pure returns (string memory version);
 
+    function token() external view returns (IPolygonEcosystemToken polygonEcosystemToken);
+
     function startTimestamp() external view returns (uint256 timestamp);
 
     function mint() external;

src/interfaces/IPolygonEcosystemToken.sol

@@ -13,6 +13,8 @@ interface IPolygonEcosystemToken is IERC20, IERC20Permit, IAccessControlEnumerab
     error MaxMintExceeded(uint256 maxMint, uint256 mintRequested);
 
     function mintPerSecondCap() external view returns (uint256 currentMintPerSecondCap);
+
+    function getVersion() external pure returns (string memory version);
 
     function lastMint() external view returns (uint256 lastMintTimestamp);
 

src/interfaces/IPolygonMigration.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.21;
 
+import {IERC20} from "openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";
+
 interface IPolygonMigration {
     error UnmigrationLocked();
     error InvalidAddressOrAlreadySet();
@@ -12,6 +14,8 @@ interface IPolygonMigration {
 
     function unmigrationLocked() external view returns (bool isUnmigrationLocked);
 
+    function polygon() external view returns(IERC20 polygonEcosystemToken);
+
     function getVersion() external pure returns (string memory version);
 
     function migrate(uint256 amount) external;

test/DefaultEmissionManager.t.sol

@@ -83,6 +83,9 @@ contract DefaultEmissionManagerTest is Test {
     function test_InvalidDeployment() external {
         address _polygon = makeAddr("polygon");
         address _governance = makeAddr("governance");
+        address _migration = makeAddr("migration");
+        address _treasury = makeAddr("treasury");
+        address _stakeManager = makeAddr("stakeManager");
 
         address proxy = address(
             new TransparentUpgradeableProxy(
@@ -102,6 +105,13 @@ contract DefaultEmissionManagerTest is Test {
         DefaultEmissionManager(proxy).initialize(address(0), _governance);
         vm.expectRevert(InvalidAddress.selector);
         DefaultEmissionManager(proxy).initialize(address(0), address(0));
+
+        vm.expectRevert(InvalidAddress.selector);
+        new DefaultEmissionManager(_migration, address(0), _treasury);
+        vm.expectRevert(InvalidAddress.selector);
+        new DefaultEmissionManager(address(0), _stakeManager, _treasury);
+        vm.expectRevert(InvalidAddress.selector);
+        new DefaultEmissionManager(_migration, _stakeManager, address(0));
     }
 
     function test_ImplementationCannotBeInitialized() external {

test/PolygonMigration.t.sol

@@ -63,6 +63,9 @@ contract PolygonMigrationTest is Test {
         temp.initialize();
         vm.expectRevert("Initializable: contract is already initialized");
         temp.initialize();
+
+        vm.expectRevert(IPolygonMigration.InvalidAddress.selector);
+        new PolygonMigration(address(0));
     }
 
     function test_Migrate(address user, uint256 amount) external {