-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error when batch limit error + add sub batch arg #192
Conversation
Not sure about the rest of the changes in the PR but just these lines fixed the issue for me. // func (ms *monitorStatus) processBatchesConcurrently(ctx context.Context, rpc *ethrpc.Client, blms []ethrpc.BatchElem) error {
retryable := func() error {
if err := rpc.BatchCallContext(ctx, subBatch); err != nil {
log.Error().Err(err).Msg("Error when performing batch calls")
return backoff.Permanent(err)
}
return nil
} |
@leovct the other changes are basically an attempt to make Ctrl+C work when BatchCall retry is happening, but it's not working as intended. |
cf75366
to
d76fa6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I hope nobody will return an error with limit
other than batch limit errors lol!
Maybe add a note that says this is a dirty hack ;)
Solc 0.8.24 just went out, that's why the CI breaks... I'll send a PR to make sure it doesn't break again! |
0f262a6
to
524cca2
Compare
log why batch call is failing so we are not lost
i made the retry + backoff a go routine… but this still prevents ctrl+c when it’s retrying 🤷
force stop batch retry when the error is “batch limit”