Optimize assembly dynamic jump#1123
Open
fractasy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes dynamic jump handling by removing low-address dynamic jump paths from the generated x86_64 assembly when the float feature is disabled, and by making ecall jump to a fixed ROM address (instead of reading MTVEC) in non-float builds.
Changes:
- Make
ecalluse an immediate fixed handler address whenfloatis disabled, avoiding a dynamic jump to low ROM. - Add non-float assertions to ensure the fixed
ecallhandler address matches the ROM layout. - Conditionally compile out low-address dynamic jump handling in the ROM-to-ASM generator when
floatis disabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/zisk_rom_2_asm.rs | Gates the low-address dynamic jump detection/handling behind feature = "float" in generated assembly. |
| core/src/riscv2zisk_context.rs | Introduces a fixed non-float ecall handler address and related ROM layout assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔄 ZisK Cycle TrackingEmulator cost report ( Summary
Per-Guest Breakdownbigint
bls12_381
bn254
diagnostic
hashes
secp256k1
secp256r1
uint256
🔴 increase (regression) · 🟢 decrease (improvement) · ➖ no change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.