Fix#1150
Merged
Merged
Conversation
xavi-pinsach
previously approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the distributed install smoke-test scripts to accept non-plain MAJOR.MINOR.PATCH values in the version= field inside the ziskup bundle metadata file (.zisk-bundle), aligning the tests with version strings that may include suffixes.
Changes:
- Relaxed
.zisk-bundleversion=validation in worker install smoke tests (Linux/macOS). - Relaxed
.zisk-bundleversion=validation in coordinator install smoke tests (Linux/macOS).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| distributed/deploy/scripts/test/worker-install-macos.sh | Loosens .zisk-bundle version regex used by the macOS worker install smoke test. |
| distributed/deploy/scripts/test/worker-install-linux.sh | Loosens .zisk-bundle version regex used by the Linux worker install smoke test. |
| distributed/deploy/scripts/test/coordinator-install-macos.sh | Loosens .zisk-bundle version regex used by the macOS coordinator install smoke test. |
| distributed/deploy/scripts/test/coordinator-install-linux.sh | Loosens .zisk-bundle version regex used by the Linux coordinator install smoke test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔄 ZisK Cycle TrackingEmulator cost report ( Summary
Per-Guest Breakdownbigint
bls12_381
bn254
diagnostic
hashes
secp256k1
secp256r1
uint256
🔴 increase (regression) · 🟢 decrease (improvement) · ➖ no change. |
xavi-pinsach
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.