Skip to content

Fix#1150

Merged
RogerTaule merged 3 commits into
pre-develop-1.0.0-betafrom
fix/deploy-scripts
Jun 25, 2026
Merged

Fix#1150
RogerTaule merged 3 commits into
pre-develop-1.0.0-betafrom
fix/deploy-scripts

Conversation

@RogerTaule

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 25, 2026 12:56
@cla-bot cla-bot Bot added the cla-signed label Jun 25, 2026
@RogerTaule RogerTaule self-assigned this Jun 25, 2026
@RogerTaule RogerTaule added the bug Something isn't working label Jun 25, 2026
@RogerTaule RogerTaule added this to the Release 1.0.0-beta milestone Jun 25, 2026
xavi-pinsach
xavi-pinsach previously approved these changes Jun 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the distributed install smoke-test scripts to accept non-plain MAJOR.MINOR.PATCH values in the version= field inside the ziskup bundle metadata file (.zisk-bundle), aligning the tests with version strings that may include suffixes.

Changes:

  • Relaxed .zisk-bundle version= validation in worker install smoke tests (Linux/macOS).
  • Relaxed .zisk-bundle version= validation in coordinator install smoke tests (Linux/macOS).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
distributed/deploy/scripts/test/worker-install-macos.sh Loosens .zisk-bundle version regex used by the macOS worker install smoke test.
distributed/deploy/scripts/test/worker-install-linux.sh Loosens .zisk-bundle version regex used by the Linux worker install smoke test.
distributed/deploy/scripts/test/coordinator-install-macos.sh Loosens .zisk-bundle version regex used by the macOS coordinator install smoke test.
distributed/deploy/scripts/test/coordinator-install-linux.sh Loosens .zisk-bundle version regex used by the Linux coordinator install smoke test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread distributed/deploy/scripts/test/worker-install-macos.sh Outdated
Comment thread distributed/deploy/scripts/test/worker-install-linux.sh Outdated
Comment thread distributed/deploy/scripts/test/coordinator-install-macos.sh Outdated
Comment thread distributed/deploy/scripts/test/coordinator-install-linux.sh Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment thread distributed/deploy/scripts/test/worker-install-linux.sh Outdated
Comment thread distributed/deploy/scripts/test/worker-install-macos.sh Outdated
Comment thread distributed/deploy/scripts/test/coordinator-install-linux.sh Outdated
Comment thread distributed/deploy/scripts/test/coordinator-install-macos.sh Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown

🔄 ZisK Cycle Tracking

Emulator cost report (ziskemu -X) comparing this PR against the base branch.

Summary

Guest Steps Δ Steps Total Cost Δ Total Cost
bigint 21,918,740 ➖ 0.00% 2,628,054,009 ➖ 0.00%
bls12_381 12,076,495 ➖ 0.00% 1,786,479,337 ➖ 0.00%
bn254 14,345,489 ➖ 0.00% 2,009,186,952 ➖ 0.00%
diagnostic 156,600 🔴 +0.24% 308,656,226 🔴 +0.01%
hashes 3,101,299 ➖ 0.00% 775,831,226 ➖ 0.00%
secp256k1 325,427 ➖ 0.00% 339,894,662 ➖ 0.00%
secp256r1 4,632,811 ➖ 0.00% 1,227,473,058 ➖ 0.00%
uint256 20,823 ➖ 0.00% 295,896,290 ➖ 0.00%

Per-Guest Breakdown

bigint
Metric Base Branch Current PR Diff Diff (%)
Total Steps 21,918,740 21,918,740 0 0.00%
Main Cost 1,490,474,320 1,490,474,320 0 0.00%
Opcodes Cost 136,685,650 136,685,675 25 0.00%
Precompiles Cost 337,634,469 337,634,469 0 0.00%
Memory Cost 369,658,265 369,658,265 0 0.00%
Variable Cost 2,334,452,704 2,334,452,729 25 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 2,628,053,984 2,628,054,009 25 0.00%
Frops Cost 153,670,359 153,670,359 0 0.00%
bls12_381
Metric Base Branch Current PR Diff Diff (%)
Total Steps 12,076,495 12,076,495 0 0.00%
Main Cost 821,201,660 821,201,660 0 0.00%
Opcodes Cost 24,528,463 24,528,463 0 0.00%
Precompiles Cost 354,130,234 354,130,234 0 0.00%
Memory Cost 293,017,700 293,017,700 0 0.00%
Variable Cost 1,492,878,057 1,492,878,057 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 1,786,479,337 1,786,479,337 0 0.00%
Frops Cost 3,281,392 3,281,392 0 0.00%
bn254
Metric Base Branch Current PR Diff Diff (%)
Total Steps 14,345,489 14,345,489 0 0.00%
Main Cost 975,493,252 975,493,252 0 0.00%
Opcodes Cost 15,945,328 15,945,328 0 0.00%
Precompiles Cost 383,188,849 383,188,849 0 0.00%
Memory Cost 340,958,243 340,958,243 0 0.00%
Variable Cost 1,715,585,672 1,715,585,672 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 2,009,186,952 2,009,186,952 0 0.00%
Frops Cost 3,163,395 3,163,395 0 0.00%
diagnostic
Metric Base Branch Current PR Diff Diff (%)
Total Steps 156,227 156,600 373 0.24%
Main Cost 10,623,436 10,648,800 25,364 0.24%
Opcodes Cost 3,258,642 3,263,735 5,093 0.16%
Precompiles Cost 349,417 349,463 46 0.01%
Memory Cost 788,618 792,948 4,330 0.55%
Variable Cost 15,020,113 15,054,946 34,833 0.23%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 308,621,393 308,656,226 34,833 0.01%
Frops Cost 1,986,236 1,988,087 1,851 0.09%
hashes
Metric Base Branch Current PR Diff Diff (%)
Total Steps 3,101,299 3,101,299 0 0.00%
Main Cost 210,888,332 210,888,332 0 0.00%
Opcodes Cost 107,702,885 107,702,885 0 0.00%
Precompiles Cost 146,463,131 146,463,131 0 0.00%
Memory Cost 17,175,598 17,175,598 0 0.00%
Variable Cost 482,229,946 482,229,946 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 775,831,226 775,831,226 0 0.00%
Frops Cost 9,851,420 9,851,420 0 0.00%
secp256k1
Metric Base Branch Current PR Diff Diff (%)
Total Steps 325,427 325,427 0 0.00%
Main Cost 22,129,036 22,129,036 0 0.00%
Opcodes Cost 4,082,616 4,082,616 0 0.00%
Precompiles Cost 14,219,244 14,219,244 0 0.00%
Memory Cost 5,862,486 5,862,486 0 0.00%
Variable Cost 46,293,382 46,293,382 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 339,894,662 339,894,662 0 0.00%
Frops Cost 3,997,675 3,997,675 0 0.00%
secp256r1
Metric Base Branch Current PR Diff Diff (%)
Total Steps 4,632,811 4,632,811 0 0.00%
Main Cost 315,031,148 315,031,148 0 0.00%
Opcodes Cost 79,204,784 79,204,784 0 0.00%
Precompiles Cost 422,156,730 422,156,730 0 0.00%
Memory Cost 117,479,116 117,479,116 0 0.00%
Variable Cost 933,871,778 933,871,778 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 1,227,473,058 1,227,473,058 0 0.00%
Frops Cost 72,520,183 72,520,183 0 0.00%
uint256
Metric Base Branch Current PR Diff Diff (%)
Total Steps 20,823 20,823 0 0.00%
Main Cost 1,415,964 1,415,964 0 0.00%
Opcodes Cost 92,935 92,935 0 0.00%
Precompiles Cost 429,971 429,971 0 0.00%
Memory Cost 356,140 356,140 0 0.00%
Variable Cost 2,295,010 2,295,010 0 0.00%
Base Cost 293,601,280 293,601,280 0 0.00%
Total Cost 295,896,290 295,896,290 0 0.00%
Frops Cost 142,292 142,292 0 0.00%

🔴 increase (regression) · 🟢 decrease (improvement) · ➖ no change. STEPS and all COSTS are deterministic functions of (ELF, input).

@RogerTaule RogerTaule merged commit d0ab68d into pre-develop-1.0.0-beta Jun 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants