Skip to content

Init should not have an optional json parameter - #10

Merged
0xWDG merged 2 commits into
mainfrom
init-fix
Oct 6, 2025
Merged

Init should not have an optional json parameter#10
0xWDG merged 2 commits into
mainfrom
init-fix

Conversation

@0xWDG

@0xWDG 0xWDG commented Oct 6, 2025

Copy link
Copy Markdown
Owner

No description provided.

@0xWDG
0xWDG requested a review from Copilot October 6, 2025 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the optional nature of the JSON parameter in DynamicUI initializers and updates type alias names to be more descriptive. The change ensures that DynamicUI always receives valid JSON data at initialization, preventing potential runtime issues from nil JSON.

  • Removes default nil values from json parameters in both initializers
  • Renames type aliases from Handler/ErrorHandler to Callback/OnError for clarity
  • Updates all references to use the new type alias names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/DynamicUI/DynamicUI.swift
@0xWDG 0xWDG self-assigned this Oct 6, 2025
@0xWDG
0xWDG merged commit 5bf49a3 into main Oct 6, 2025
5 checks passed
@0xWDG
0xWDG deleted the init-fix branch October 6, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants