test(BuyModal): add tests for checkout mode determination logic #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract determineCheckoutMode into separate testable function - Add 9 unit tests covering all checkout mode scenarios: - Trails mode with chain/order support - Trails fallback to crypto when not supported - Sequence-checkout mode passthrough - Crypto mode explicit config - Undefined config handling - Export missing CreateListingModalContext type
AlexanderKolberg
requested review from
a team and
0xsequence-bot
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
determineCheckoutModeinto a separate testable pure functionCreateListingModalContexttype for headless implementationsChanges
New Files
sdk/src/react/ui/modals/BuyModal/internal/determineCheckoutMode.ts- Extracted checkout mode logicsdk/src/react/ui/modals/BuyModal/internal/__tests__/determineCheckoutMode.test.ts- 9 unit testsModified Files
sdk/src/react/ui/modals/BuyModal/internal/buyModalContext.ts- Use extracted functionsdk/src/react/ui/index.ts- ExportCreateListingModalContexttypeTest Coverage
Context
This improves v2 release readiness by: