feat: add support for react 19 #3545
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated React from v18 to v19.2.0 in all packages - Updated React-DOM to v19.2.0 where used - Updated @types/react and @types/react-dom to v19.2.0 - Updated peer dependency ranges to support React v19 Affected packages: - examples/prebuilt-react-integration - packages/react-icons - packages/roomkit-react - packages/hms-whiteboard - packages/react-sdk 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…patibility Fixed JSX runtime errors by preventing bundling of react/jsx-runtime in both react-sdk and react-icons packages. Updated rollup configurations to: - Add 'react/jsx-runtime' to external dependencies - Configure esbuild with automatic JSX transform - Ignore jsx-runtime in commonjs plugin Also added React 18 example app to verify backward compatibility and removed unnecessary empty fragment default in SettingsModal. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added postinstall script to patch react-primitive NODES array to include 'input'. This fixes the RadioBubbleInput undefined error in @radix-ui/react-slider with React 19. The patch adds 'input' to the NODES array in all instances of @radix-ui/react-primitive that are nested within other Radix UI packages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated all Radix UI packages to their exact latest versions without carets: - @radix-ui/react-accordion: ^1.2.2 → 1.2.12 - @radix-ui/react-checkbox: ^1.1.2 → 1.3.3 - @radix-ui/react-collapsible: ^1.1.1 → 1.1.12 - @radix-ui/react-dialog: ^1.1.2 → 1.1.15 - @radix-ui/react-dropdown-menu: ^2.1.2 → 2.1.16 - @radix-ui/react-label: ^2.1.1 → 2.1.7 - @radix-ui/react-popover: ^1.1.2 → 1.1.15 - @radix-ui/react-progress: ^1.1.1 → 1.1.7 - @radix-ui/react-radio-group: ^1.2.1 → 1.3.8 - @radix-ui/react-select: ^2.1.2 → 2.2.6 - @radix-ui/react-slider: ^1.2.1 → 1.3.6 - @radix-ui/react-switch: ^1.1.1 → 1.2.6 - @radix-ui/react-tabs: ^1.1.1 → 1.1.13 - @radix-ui/react-toast: ^1.2.2 → 1.2.15 - @radix-ui/react-tooltip: ^1.1.4 → 1.2.8 All packages now use exact versions for better reproducibility. The postinstall patch ensures React 19 compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replaced the postinstall patch script with a Yarn resolution to force all packages (including tldraw's old dependencies) to use @radix-ui/[email protected], which includes 'input' in its NODES array. This is a cleaner solution that: - Eliminates the need for patch-package and postinstall-postinstall - Ensures consistent react-primitive version across all dependencies - Works automatically on yarn install without custom scripts - Version 2.1.3 natively includes 'input' element support Removed: - scripts/patch-radix-primitive.sh - patch-package dependency - postinstall-postinstall dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add post-build step to inline tldraw CSS into roomkit-react/dist/index.css - Remove runtime CSS import from WhiteboardLayout component - CSS now bundled at build time, no external configuration needed Note: tldraw v2.0.0-alpha.19 has React 18 JSX runtime incompatibility with React 19 that cannot be resolved at library level without user configuration or upgrading tldraw. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This commit upgrades all @radix-ui packages to their latest versions that support React 19. Changes include: - Upgraded all Radix UI primitive packages to latest versions - Updated component implementations to use new Radix UI APIs - Removed unused magic-string dev dependency - Updated yarn.lock with new dependencies All Radix UI components now work correctly with React 19: - Accordion, Checkbox, Collapsible, Dialog, Dropdown - Label, Popover, Progress, RadioGroup, Select - Sheet, Slider, Switch, Tabs, Toast, Tooltip 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Implementation note, gotchas, related work and Future TODOs (optional)
Pre-launch Checklist
Merging: