Ciexample/branch #595
Ciexample/branch #595
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies across multiple applications in a monorepo, including major version bumps for esbuild (0.20.2 → 0.27.2), various Babel packages, Express ecosystem packages, and ESLint plugins. It also adds branch triggers to the CI/CD workflow configuration.
Key Changes:
- Upgraded esbuild from v0.20.2 to v0.27.2 across the monorepo
- Updated @next/eslint-plugin-next with inconsistent versions between apps
- Updated multiple Babel packages to v7.27-7.28 range
- Updated Express and related middleware packages
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Major dependency updates including esbuild, Babel packages, Express ecosystem, Next.js plugins, and various other npm packages |
| apps/user-app/package.json | Added esbuild 0.27.2, updated @next/eslint-plugin-next to 16.0.10 |
| apps/merchant-app/package.json | Added esbuild 0.27.2, updated @next/eslint-plugin-next to 14.2.35 |
| apps/bank-webhook/package.json | Updated esbuild from ^0.20.2 to ^0.27.2 |
| apps/user-app/next-env.d.ts | Updated documentation URL comment |
| apps/merchant-app/next-env.d.ts | Updated documentation URL comment |
| .github/workflows/build.yml | Added three new branch names to PR trigger list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "devDependencies": { | ||
| "@next/eslint-plugin-next": "^14.1.1", | ||
| "@next/eslint-plugin-next": "^16.0.10", |
There was a problem hiding this comment.
The version 16.0.10 for @next/eslint-plugin-next is inconsistent with the Next.js version being used (^14.1.1). The eslint plugin version (16.x) is ahead of the Next.js framework version (14.x), which could lead to incompatibility issues. This package should typically match or be compatible with the Next.js version in use.
| "@next/eslint-plugin-next": "^16.0.10", | |
| "@next/eslint-plugin-next": "^14.1.1", |
| "esbuild": "0.27.2", | ||
| "next": "^14.1.1", | ||
| "next-auth": "^4.24.7", |
There was a problem hiding this comment.
The esbuild version is pinned to an exact version 0.27.2 without a caret or tilde, which prevents automatic minor/patch updates. Consider using ^0.27.2 to allow compatible updates while maintaining version consistency across the monorepo.
| "esbuild": "0.27.2", | |
| "next": "^14.1.1", | |
| "next-auth": "^4.24.7", | |
| "esbuild": "^0.27.2", | |
| "next": "^14.1.1", | |
| "next-auth": "^4.24.7", |
| "@repo/db": "*", | ||
| "@repo/store": "*", | ||
| "@repo/ui": "*", | ||
| "esbuild": "0.27.2", |
There was a problem hiding this comment.
The esbuild version is pinned to an exact version 0.27.2 without a caret or tilde, which prevents automatic minor/patch updates. Consider using ^0.27.2 to allow compatible updates while maintaining version consistency across the monorepo.
| "esbuild": "0.27.2", | |
| "esbuild": "^0.27.2", |
| - master | ||
| - main | ||
| - example | ||
| - example 2 |
There was a problem hiding this comment.
The branch name example 2 contains a space, which is unusual and may cause issues with certain Git operations or tooling. Consider using a hyphen or underscore instead, such as example-2 or example_2.
| - example 2 | |
| - example-2 |
1 participant
No description provided.