Branch/example #596
Branch/example #596
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates dependency versions across the monorepo and modifies GitHub workflow triggers. The main changes include upgrading esbuild, various Babel packages, and Next.js-related dependencies, along with adding branch triggers to CI/CD workflows.
Key changes:
- Upgraded esbuild from 0.20.2 to 0.27.2 across multiple apps
- Updated @next/eslint-plugin-next versions (inconsistently between apps)
- Updated various Babel packages and other dependencies in package-lock.json
- Added new branch triggers (main, example, example 2) to GitHub workflows
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Comprehensive dependency updates including esbuild, Babel packages, Express, Next.js tooling, and many other packages |
| apps/user-app/package.json | Added esbuild 0.27.2 dependency and upgraded @next/eslint-plugin-next to 16.0.10 |
| apps/merchant-app/package.json | Added esbuild 0.27.2 dependency and upgraded @next/eslint-plugin-next to 14.2.35 |
| apps/bank-webhook/package.json | Updated esbuild from 0.20.2 to 0.27.2 |
| apps/user-app/next-env.d.ts | Updated TypeScript documentation reference URL |
| apps/merchant-app/next-env.d.ts | Updated TypeScript documentation reference URL |
| .github/workflows/deploy.yml | Added 'main' and 'example' branch triggers |
| .github/workflows/build.yml | Added 'main', 'example', and 'example 2' branch triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@repo/ui": "*", | ||
| "@types/bcrypt": "^5.0.2", | ||
| "bcrypt": "^5.1.1", | ||
| "esbuild": "0.27.2", |
There was a problem hiding this comment.
The esbuild version is pinned to an exact version (0.27.2) instead of using a semver range like other dependencies. Consider using a caret range (^0.27.2) to allow for patch updates, or document why an exact version is required.
| "esbuild": "0.27.2", | |
| "esbuild": "^0.27.2", |
| "@repo/db": "*", | ||
| "@repo/store": "*", | ||
| "@repo/ui": "*", | ||
| "esbuild": "0.27.2", |
There was a problem hiding this comment.
The esbuild version is pinned to an exact version (0.27.2) instead of using a semver range. Consider using a caret range (^0.27.2) to allow for patch updates, or document why an exact version is required.
| "esbuild": "0.27.2", | |
| "esbuild": "^0.27.2", |
| - master | ||
| - main | ||
| - example | ||
| - example 2 |
There was a problem hiding this comment.
The branch name "example 2" contains a space which is unconventional for Git branch names. Consider using kebab-case naming convention like "example-2" instead.
| - example 2 | |
| - example-2 |
1 participant
No description provided.