-
-
Notifications
You must be signed in to change notification settings - Fork 519
Migrate to flat ESLint flat config and remove cross-env #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- migrated ESLint configuration to new flat config format - removed usage of FlatCompat and .eslintrc* dependency - switched stylistic rules to @stylistic/eslint-plugin-js
Added an ignore field to silence unnecessary ESLint warnings in test files. This removes the bulk of the noise, but there are still a few lingering warnings left. Not sure yet how best to handle those, so I'll keep this PR as a draft for now |
Ah, sorry — what is the benefit here? Seems like if I’m going to use ESLint it’s better to stick ESLint packages directly, no? |
You're talking about the ignores field? I'm just worried about a big bunch of warnings (over 200 I believe) after running lint command from root, so that's the workaround I've come up with. If the presence of these warnings does not interfere - I'll remove this field, no problem 😅 |
Ah, no sorry — I mean the use of |
Ahh, with the ESLint v9 release, they just moved the stylistic rules out of the core and put them into separate stylistic plugin. So if you search for a rule like Source: https://eslint.org/docs/latest/rules/space-unary-ops They deprecated these style rules from the core because they were becoming a massive maintenance burden, suggesting formatters or the @Stylistic plugins as the new home for style rules. |
No description provided.