Skip to content

Conversation

@frankdekker
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings September 19, 2025 14:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a mandatory GitLab synchronization feature that forces users to connect their GitLab accounts before they can continue using the application. The implementation includes an event subscriber that intercepts requests and redirects users to a mandatory sync page if they haven't connected their GitLab account and the feature is enabled.

Key changes:

  • Added a new event subscriber to check for GitLab sync requirements on every request
  • Created a new controller and template for the mandatory sync page
  • Extended the existing git sync functionality to support both comment and reviewer sync
  • Added configuration support for the mandatory sync feature

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/EventSubscriber/MandatoryGitlabSyncSubscriber.php Core event subscriber that enforces mandatory GitLab sync by redirecting users
src/Controller/App/User/UserMandatoryGitlabSyncController.php Controller for displaying the mandatory sync page
templates/app/user/user.gitlab.sync.mandatory.html.twig Template for the mandatory sync warning page
src/Controller/App/User/UserGitSyncController.php Updated to support both comment and reviewer sync functionality
config/services.php Added binding for the new mandatory sync configuration
.env Added environment variable for mandatory sync feature
translations/messages+intl-icu.en.php Added translation key for mandatory sync message
tests/Unit/EventSubscriber/MandatoryGitlabSyncSubscriberTest.php Comprehensive test coverage for the event subscriber
tests/Unit/Controller/App/User/UserMandatoryGitlabSyncControllerTest.php Basic test for the mandatory sync controller
tests/Unit/Controller/App/User/UserGitSyncControllerTest.php Updated test to match new constructor signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (a6fe33a) to head (c1e9c04).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1208   +/-   ##
=========================================
  Coverage     99.98%   99.98%           
- Complexity     3337     3348   +11     
=========================================
  Files           580      582    +2     
  Lines          9910     9932   +22     
=========================================
+ Hits           9909     9931   +22     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frankdekker frankdekker merged commit 2b5c034 into master Sep 19, 2025
5 checks passed
@frankdekker frankdekker deleted the Make-gitlab-sync-mandatory branch September 19, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants