Skip to content

Conversation

@frankdekker
Copy link
Member

…the file was renamed.

Copilot AI review requested due to automatic review settings September 19, 2025 15:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the file search functionality to find files by their original path before they were renamed. This addresses scenarios where a file has been renamed but consumers need to locate it using its previous file path.

  • Enhanced the findFileByPath method to also search for renamed files using their original paths
  • Added logic to track and return files that match the search path in their pre-rename state
  • Updated test expectations to verify the new rename-aware search behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Service/CodeReview/DiffFinder.php Added logic to search for files by their original path before rename and return rename matches as fallback
tests/Unit/Service/CodeReview/DiffFinderTest.php Updated test assertion to expect finding renamed file by its original path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (4dede86) to head (d85a3a8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1210   +/-   ##
=========================================
  Coverage     99.98%   99.98%           
- Complexity     3348     3350    +2     
=========================================
  Files           582      582           
  Lines          9932     9935    +3     
=========================================
+ Hits           9931     9934    +3     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frankdekker frankdekker merged commit 9600b67 into master Sep 19, 2025
5 checks passed
@frankdekker frankdekker deleted the When-selecting-file-from-review-also-match-original-filename branch September 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants