Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@symfony/webpack-encore ^4.6.1 -> ^5.0.0 age adoption passing confidence

Release Notes

symfony/webpack-encore (@​symfony/webpack-encore)

v5.0.0

Compare Source

This is a new major version that contains several backwards-compatibility breaks.

Features
  • #​1344 Add options configuration callback to Encore.enableReactPreset() (@​Kocal)

  • #​1345 Add support for integrity hashes when asset names contain a query string (@​Kocal)

BC Breaks

The dev-server options have changed between versions 4 and 5, see the official migration guide to v5.
For example:

// With webpack-dev-server 4:
Encore.configureDevServerOptions((options) => {
   options.https = {
     ca: "./path/to/server.pem",
     pfx: "./path/to/server.pfx",
     key: "./path/to/server.key",
     cert: "./path/to/server.crt",
     passphrase: "webpack-dev-server",
     requestCert: true,
   };
});

// With webpack-dev-server 5 (now):
Encore.configureDevServerOptions((options) => {
   options.server = {
      type: 'https',
      options: {
         ca: "./path/to/server.pem",
         pfx: "./path/to/server.pfx",
         key: "./path/to/server.key",
         cert: "./path/to/server.crt",
         passphrase: "webpack-dev-server",
         requestCert: true,
      }
   };
});

The webpack-dev-server package is now an optional peer dependency.
It has been removed because some projects may not use it, and it was installing a bunch of unnecessary dependencies.

Removing the webpack-dev-server dependency from Encore reduces the number of dependencies from 626 to 295 (-331!),
it helps to reduce the size of the node_modules directory and the number of possible vulnerabilities.

To use the webpack-dev-server again, you need to install it manually:

npm install webpack-dev-server --save-dev

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label Sep 30, 2024
@renovate
Copy link
Contributor Author

renovate bot commented Sep 30, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @symfony/[email protected]
npm error Found: [email protected]
npm error node_modules/sass-loader
npm error   dev sass-loader@"^14.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional sass-loader@"^16.0.1" from @symfony/[email protected]
npm error node_modules/@symfony/webpack-encore
npm error   dev @symfony/webpack-encore@"^5.0.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/sass-loader
npm error   peerOptional sass-loader@"^16.0.1" from @symfony/[email protected]
npm error   node_modules/@symfony/webpack-encore
npm error     dev @symfony/webpack-encore@"^5.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-09-30T05_18_17_290Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-09-30T05_18_17_290Z-debug-0.log

@renovate
Copy link
Contributor Author

renovate bot commented Sep 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (4a8e6b4) to head (cf8db01).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #866   +/-   ##
=========================================
  Coverage     99.98%   99.98%           
  Complexity     3086     3086           
=========================================
  Files           529      529           
  Lines          8539     8539           
=========================================
  Hits           8538     8538           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankdekker frankdekker merged commit 38257b9 into master Sep 30, 2024
3 checks passed
@frankdekker frankdekker deleted the renovate/major-webpack branch September 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants