Skip to content

warning when custom coverage is above or equal to global coverage #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

warning when custom coverage is above or equal to global coverage #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d958cc6
B#187800 PHPFCI: warning when custom coverage is above or equal to gl…
anne-gaelle123inkt Oct 30, 2024
3d8167a
B#187800 PHPFCI: warning when custom coverage is above or equal to gl…
anne-gaelle123inkt Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Lib/Metrics/Inspection/CustomCoverageAboveGlobalInspection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function inspect(?PathInspectionConfig $fileConfig, FileMetric $metric):
$customCoverage = $fileConfig->getMinimumCoverage();

// custom coverage is lower than global coverage, and file is above global coverage
if ($customCoverage < $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
if ($customCoverage <= $globalCoverage && $metric->getCoverage() >= $globalCoverage) {
return new Failure($metric, $fileConfig->getMinimumCoverage(), Failure::UNNECESSARY_CUSTOM_COVERAGE);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Lib/Config/ConfigFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function testCreateInspectConfigDuplicateOutputReport(): void
touch($coveragePath);

$input = $this->createMock(InputInterface::class);
$input->expects(self::exactly(5))->method('getOption')->willReturn($configPath, null, null, null);
$input->expects(self::exactly(5))->method('getOption')->willReturn($configPath, null, null, null, null);
$input->expects(self::once())->method('getArgument')->with('coverage')->willReturn([$coveragePath]);

$config = $this->factory->createInspectConfig($input);
Expand Down