Prepare 1.0 release: #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All components are now configured with `$config->{component}()->enabled()`.
-- Previously some were `$config->enable{component}()` and others `$config->{component}()->enabled()`
-- This makes it easier in the future to add more settings for these components
- messenger is now enabled by default
-- To have full tracing by default
- Marked some more classes as @internal
-- As this is a bundle and not a library to use, only the bundle configuration and the required interfaces should be used outside this bundle
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 1.0 release by unifying component enable flags as nested enabled arrays, enabling messenger by default, and marking internal classes with @internal.
- Consolidate all component flags (
monolog,console,messenger,twig) under array nodes with anenabledchild - Change messenger integration to be enabled by default in both config and tests
- Annotate internal classes and compiler passes with
@internal
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Functional/App/config/traceid.yml | Replace enable_messenger with messenger.enabled |
| tests/Functional/App/config/tracecontext.yml | Replace enable_messenger with messenger.enabled |
| src/TraceStorage.php | Add @internal annotation to TraceStorage |
| src/Service/TraceContext/TraceContextParser.php | Add @internal annotation to TraceContextParser |
| src/Messenger/TraceStamp.php | Add @internal annotation to TraceStamp |
| src/Http/TraceAwareHttpClient.php | Add @internal annotation to TraceAwareHttpClient |
| src/Generator/TraceId/SymfonyUuid4Generator.php | Add @internal annotation |
| src/Generator/TraceId/RamseyUuid4Generator.php | Add @internal annotation |
| src/DependencyInjection/SymfonyTraceExtension.php | Updated service configuration checks and replaced flat flags |
| src/DependencyInjection/Configuration.php | Switched boolean nodes to array nodes for all enabled flags |
| src/DependencyInjection/Compiler/HttpClientTracePass.php | Mark compiler pass as @internal |
| phpstan-baseline.neon | Adjust baseline regex for updated config structure |
| docs/configuration/traceid.md | Updated example calls to use new monolog(), messenger(), twig() APIs |
| docs/configuration/tracecontext.md | Updated example calls to use new monolog(), messenger(), twig() APIs |
| README.md | Updated default notes for HTTP client and messenger settings |
Change readme config notation
frankdekker
reviewed
Jun 3, 2025
frankdekker
reviewed
Jun 3, 2025
frankdekker
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$config->{component}()->enabled(). -- Previously some were$config->enable{component}()and others$config->{component}()->enabled()-- This makes it easier in the future to add more settings for these components