fix: Remove spurious new uuid7 dependency#268
Merged
Conversation
This was added in 15r10nk#224, but nothing actually imports from the uuid_extensions module it provides.
Owner
|
ohh, thank you. I wanted to use uuid7 because the externals could be ordered based on the time but did not used it in the end. I forgot to remove the dependency. sorry and thank you for finding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
uuid7dependency was added in #224, but nothing actually imports from theuuid_extensionsmodule it provides. This is probably just as well, since stevesimmons/uuid7#1 suggests it has issues.Description
This PR removes the spurious/unused dependency on the
uuid7package.Related Issue(s)
Checklist
hatch run cov:github).hatch run changelog:entryfeat:will cause a major andfix:a minor version bump)