fix: get_snapshot_value returns old_value#337
Open
qdewaghe wants to merge 1 commit into15r10nk:mainfrom
Open
Conversation
`get_snapshot_value` used to return `...` if the snapshot was not asserted. Now, it returns the old value if there is one. Returning the old value should be fine because if the new value does not match the old then a prior assertion has failed.
qdewaghe
force-pushed
the
fix/get_snapshot_value
branch
from
cefd9a9 to
f3d74d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm misunderstanding this but I would expect
get_snapshot_valueto return the snapshot value even if no assertion has been made yet.Description
get_snapshot_valueused to return...if the snapshot was not asserted.Now, it returns the old value if there is one. Returning the old value should be fine because if the new value does not match the old then a prior assertion has failed.
Related Issue(s)
#336
Checklist
hatch run cov:github).hatch run changelog:entryfeat:will cause a major andfix:a minor version bump)