Skip to content

[Feature] Order queries by date descending instead of ID ascending #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levinmr wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Feature] Order queries by date descending instead of ID ascending #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const queryDomain = (
// pulls from Google Analytics) happens to be in order by visits or total_events, so ordering by
// IDs may in practice keep the same ordering as before - but it would be best not to rely on this.
// A longer term fix would be to move the total_events and visits fields to their own columns.
.orderBy("id", "asc")
//.orderBy("id", "asc")
.limit(limitParam)
.offset((pageParam - 1) * limitParam)
);
Expand Down Expand Up @@ -152,7 +152,7 @@ const query = ({
// pulls from Google Analytics) happens to be in order by visits or total_events, so ordering by
// IDs may in practice keep the same ordering as before - but it would be best not to rely on this.
// A longer term fix would be to move the total_events and visits fields to their own columns.
.orderBy("id", "asc")
//.orderBy("id", "asc")
.limit(limitParam)
.offset((pageParam - 1) * limitParam)
);
Expand Down