Skip to content

Conversation

@shilenpatel1
Copy link
Contributor

@shilenpatel1 shilenpatel1 commented Nov 18, 2025

🎫 Ticket

GL_Data_Reporting-398

Link to the relevant ticket:
GL_Data_Reporting-398

🛠 Summary of changes

Write a brief description of what you changed.
--> Implement SPVerification report job that expands the capability of sending the report to differnet agency, not just the IRS.
--> Implement SPVerificationReport at lib/reporting/sp_verification_report.rb, that generates the actual report
--> Added sp_verification_report_configs in identity_config and set the default value for that.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1 Tested report generation using local rails console with providing default sp_verification_report_configs
  • Step 2 Run unit tests for spec files in this PR (i.e. bundle exec rspec ./spec/path/to/spec_file)

Testing with giving Single Service providers

Send email to internal:

Screenshot 2025-11-14 at 3 58 36 PM Screenshot 2025-11-14 at 3 58 44 PM

Send email to both:

Screenshot 2025-11-14 at 3 58 54 PM Screenshot 2025-11-14 at 3 59 04 PM

Testing with giving multiple Service providers

Here, is the rails console local testing:

Screenshot 2025-12-03 at 8 41 02 AM Screenshot 2025-12-03 at 8 46 55 AM Screenshot 2025-12-03 at 8 47 10 AM Screenshot 2025-12-03 at 8 47 17 AM

Here is the report output in browser, I got 2 reports one for each service provider:

Screenshot 2025-12-03 at 2 46 39 PM Screenshot 2025-12-03 at 2 46 45 PM

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Testing inside Local Rails Console:

Before:
After:

@shilenpatel1 shilenpatel1 force-pushed the 252_SP_Verification_report branch from b1eb586 to fba2bfa Compare November 19, 2025 22:03
@shilenpatel1 shilenpatel1 changed the title 252 sp verification report GL_Data_Reporting-252: Add SP verification report Nov 19, 2025
Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this report to job config. Discuss specific report changes in #12685

@shilenpatel1
Copy link
Contributor Author

shilenpatel1 commented Nov 21, 2025

#12685

@astrogeco I thought to do that, but as of now if we will add that to job config, once deployed it will start sending an email. Do we want that? Also, sp_verification_report_configs is not yet available in any environment, once this will merged and deployed I can see that in secrets and edit that right

@astrogeco
Copy link
Contributor

#12685

@astrogeco I thought to do that, but as of now if we will add that to job config, once deployed it will start sending an email. Do we want that? Also, sp_verification_report_configs is not yet available in any environment, once this will merged and deployed I can see that in secrets and edit that right

yes, we want it to send internal emails only

@astrogeco
Copy link
Contributor

Before the PR deploys we should add the new parameters in the secrets manager

@shilenpatel1
Copy link
Contributor Author

should add the new parameters in

@astrogeco I have added in dev and int
Screenshot 2025-11-21 at 4 45 46 PM

@shilenpatel1
Copy link
Contributor Author

should add the new parameters in

@astrogeco Job config is also added

@koseni123
Copy link
Contributor

@shilenpatel1 Did you test for mutiple server providers? Please include full screenshot of report showing the overview section where the SP is shown.

@shilenpatel1
Copy link
Contributor Author

@shilenpatel1 Did you test for mutiple server providers? Please include full screenshot of report showing the overview section where the SP is shown.

@koseni123 I tested it with multiple service p[roviders also, it worked! I put the screenshots in ticker. Also, there is full screenshot of the report.

Copy link
Contributor

@koseni123 koseni123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilenpatel1
Copy link
Contributor Author

@astrogeco I have made all requested changes, can you please review this PR?

@shilenpatel1 shilenpatel1 force-pushed the 252_SP_Verification_report branch 2 times, most recently from 3a842b2 to e2d94c1 Compare December 12, 2025 02:35
@shilenpatel1 shilenpatel1 force-pushed the 252_SP_Verification_report branch from e2d94c1 to eb63aca Compare December 12, 2025 02:49
args: -> { [Time.zone.yesterday.end_of_day, :both] },
},

# Send previous week's verification reports to partners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the comment to indicate this is currently for testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

@astrogeco
Copy link
Contributor

Left some comments in #12742

@shilenpatel1 shilenpatel1 changed the title GL_Data_Reporting-252: Add SP verification report GL_Data_Reporting-398: Add SP verification report Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants