change reportMailer definition and specs (DoNotMerge) #12740
+82
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Reporting, Update ReportMailer, and its caller see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367
changelog: Internal, Reporting, Update ReportMailer, and its caller see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367
shilenpatel1
force-pushed
the
367_norm_reportmailer_sign
branch
from
b250b15 to
38ef02b
Compare
koseni123
approved these changes
Dec 15, 2025
shilenpatel1
requested review from
adam-grandt-tts and
astrogeco
and removed request for
adam-grandt-tts
astrogeco
requested changes
Dec 17, 2025
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Looks good with one nit
| let(:mail) do | ||
| ReportMailer.tables_report( | ||
| email: '[email protected]', | ||
| to: '[email protected]', |
Contributor
There was a problem hiding this comment.
we need a spec check for cc and bcc
Contributor
Author
There was a problem hiding this comment.
Done, added checks for CC and BCC
* changelog: Internal, Reporting, add spec for BCC and CC see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367
astrogeco
approved these changes
Dec 19, 2025
astrogeco
changed the title
shilenpatel1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Reporting, Update ReportMailer, and its caller
see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367
🎫 Ticket
GL_Data_Reporting-367
Link to the relevant ticket:
GL_Data_Reporting-367
🛠 Summary of changes
Write a brief description of what you changed.
--> Updated ReportMailer.tables_report to use a to: keyword argument instead of email.
--> All reports calling ReportMailer.tables_report are updated to use to: instead of email:.
--> Related specs are updated
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: