GL_Data_reporting_369: Add changes for genericizing IRSFraudMetricReport #12757
+869
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changelog: Internal, Reporting, genericize IRSFraudMetricReport see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/369
shilenpatel1
force-pushed
the
369_sp_fraud_metric_report
branch
from
ec5c9e6 to
cf7f7d0
Compare
* changelog: Internal, Reporting, Fix spec files see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
GL_Data_Reporting-369
Link to the relevant ticket:
GL_Data_Reporting-369
🛠 Summary of changes
Write a brief description of what you changed.
--> Implement SpFraudMetricsReport report job that expands the capability of sending the report to differnet agency, not just the IRS.
--> Implement SpFraudMetricsLg99Report at lib/reporting/sp_fraud_metrics_lg99_report.rb, that generates the actual report
--> Added sp_fraud_metrics_report_configs in identity_config and set the default value for that.
--> Added unit tests for SpFraudMetricsReport in spec file at spec/jobs/reports/sp_fraud_metrics_report_spec.rb
--> Added unit tests for SpFraudMetricsLg99Report in spec file at spec/lib/reporting/sp_fraud_metrics_lg99_report_spec.rb
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
Local testing:
Stub all AWS calls, to avoid call to AWS:
Run SpFraudMetricsReport to send to :both
Added specs for Lib and job: