This repository was archived by the owner on Nov 7, 2018. It is now read-only.
allow for multiple null_value mappings in the data dictionary #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the need for multiple field values to map to a
NULLvalue in the API. Thisis related to RTICWDT/college-scorecard#903.
Currently, config.null_value and map_column_types methods only allow for a single string value in the data dictionary to be mapped to null when encountered in the csv data during import. The default has been the string
"NULL"if no data dictionary entry was found.This PR allows for the
null_valueto be defined as an array OR a single entry when the column type's are mapped and will give more flexibility for other field value instances that should be mapped to null.