Skip to content

Destroy zone on parent/part deletion - Closes #45 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sluethen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Destroy zone on parent/part deletion - Closes #45 #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Zone/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Zone.enum = enum


-- CONSTRUCTORS
function Zone.new(container)
function Zone.new(container: {BasePart} | BasePart)
local self = {}
setmetatable(self, Zone)

Expand Down Expand Up @@ -76,6 +76,7 @@ function Zone.new(container)
self.worldModel = workspace
self.onItemDetails = {}
self.itemsToUntrack = {}
self.destroyed = false

-- This updates _currentEnterDetection and _currentExitDetection right away to prevent nil comparisons
ZoneController.updateDetection(self)
Expand Down Expand Up @@ -141,6 +142,18 @@ function Zone.new(container)
ZoneController._deregisterZone(self)
end, true)

janitor:Add(function()
self.destroyed = true
end,true)

for _, v: Instance in pairs(if (typeof(container) == "Instance") then {container} else container) do
v.Destroying:Once(function()
if not self.destroyed then
self:Destroy()
end
end)
end

return self
end

Expand Down