Add a new annotation to define a env-file for the run command per container#73
Open
fabiosammy wants to merge 1 commit into
Open
Add a new annotation to define a env-file for the run command per container#73fabiosammy wants to merge 1 commit into
fabiosammy wants to merge 1 commit into
Conversation
Added support for run environment file annotations in container mutation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
Added support for run environment file annotations in container mutation.
🔗 Resolves:
So, the idea behind this is to use a file that is already in the container, defining the list of environments instead of updating the k8s manifests every time a new environment is needed.
✅ Checklist
🕵️ Review Notes &⚠️ Risks
This is my first time contributing to a "go" repository. I did it using the Claude AI, so sorry about that.
I feel that this should not be here, but a new environment should be available, something like
OP_RUN_ENV_FILE, but I could not figure out which project I should contribute to.