load-secrets-action: Add Docker Hub fallback for CLI version resolution#173
Merged
Merged
Conversation
JillRegan
marked this pull request as ready for review
July 14, 2026 19:18
JillRegan
commented
Jul 15, 2026
bertrmz
reviewed
Jul 15, 2026
bertrmz
reviewed
Jul 16, 2026
scottisloud
reviewed
Jul 16, 2026
scottisloud
left a comment
There was a problem hiding this comment.
No feedback to add beyond what Bert's already flagged!
bertrmz
reviewed
Jul 17, 2026
bertrmz
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolving the latest CLI version currently depends on a single request to
app-updates.agilebits.com. When that endpoint has an outage the action fails and breaks users' CI.This adds two fallback tiers so version resolution survives an outage:
1password/opimage tags, on separate infrastructureIf a tier fails, resolution falls through to the next. The action should not fail as final constant is pinned version.
How
getLatestVersionnow triesapp-updatesfirst and falls back to the Docker Hub tags API.N.N.Nfor stable,N.N.N-beta.Nfor beta) and picks the highest version. Beta tags aren't valid semver (leading zero), so they're normalized only for comparison and returned unchanged.src/op-cli-installer/version/fallback-versions.tsholds the last known stable and beta versions, regenerated from app-updates vianpm run op-version(run at release time, see release instructions).Testing
latestandlatest-beta) blackhole hosts via/etc/hostsand verify the correct version still installsIn the E2E test here you can see the warning that we fell back to Docker and successfully resolved the correct version.
In the E2E test here you can see the warning that we fell back to pinned version and successfully resolved the correct version.
I also refactored the E2E test setup. E2E tests for the action were redundant and flakey and often led to rate limiting issues on the test account (these tests had ~200 read requests each run). There was no need to be testing that many different combinations of the same read so i refactored to reduce it to around 30 reads. The following now runs:
Service Account (ubuntu, latest, export-env=false)
Service Account (ubuntu, latest, export-env=true)
Service Account smoke (macOS, latest)
Service Account smoke (Windows, latest)
Connect (ubuntu, latest)
Install pinned CLI (ubuntu, 2.30.0)
Docker Hub fallback (ubuntu, latest)
Docker Hub fallback (ubuntu, latest-beta)
Baked-in fallback (ubuntu, latest)
Baked-in fallback (ubuntu, latest-beta)