fix: 粉爪方案二调整延迟时间和添加定位点以优化操作流畅性#260
Merged
Merged
Conversation
Contributor
审阅者指南此 PR 通过微调 PinkPawHeistScheme2Action 中移动、跳跃、交互以及镜头操作的时序（调整若干延迟和循环次数，并插入一个短暂的修正侧移片段），以提升整套自动化流程的流畅度和稳定性。 更新后的 PinkPawHeistScheme2Action 走廊接近与战利品交互流程时序图sequenceDiagram
participant PinkPawHeistScheme2Action as Action
participant ah
participant Controller
Action->>ah: key_down(D)
Action->>ah: delay(7000)
Action->>ah: key_up(D)
Action->>ah: delay(100)
Action->>ah: key_down(A)
Action->>ah: delay(300)
Action->>ah: key_up(A)
Action->>ah: delay(100)
loop loot_right_front_showcase
Action->>ah: click_key(F)
Action->>ah: delay(200)
end
Action->>ah: key_down(S)
Action->>ah: delay(1950)
Action->>ah: key_up(S)
loop loot_backward
Action->>ah: click_key(F)
Action->>ah: delay(200)
end
文件级变更
提示与命令与 Sourcery 交互
自定义你的体验打开你的 控制面板 以：
获取帮助Original review guide in EnglishReviewer's GuideThis PR fine-tunes the timing of movement, jumping, interaction, and camera actions in PinkPawHeistScheme2Action by adjusting delays and a few loop counts, plus inserting a small corrective strafe segment, to improve the smoothness and reliability of the automation sequence. Sequence diagram for updated PinkPawHeistScheme2Action corridor approach and loot interactionsequenceDiagram
participant PinkPawHeistScheme2Action as Action
participant ah
participant Controller
Action->>ah: key_down(D)
Action->>ah: delay(7000)
Action->>ah: key_up(D)
Action->>ah: delay(100)
Action->>ah: key_down(A)
Action->>ah: delay(300)
Action->>ah: key_up(A)
Action->>ah: delay(100)
loop loot_right_front_showcase
Action->>ah: click_key(F)
Action->>ah: delay(200)
end
Action->>ah: key_down(S)
Action->>ah: delay(1950)
Action->>ah: key_up(S)
loop loot_backward
Action->>ah: click_key(F)
Action->>ah: delay(200)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些总体反馈：
- 这里出现了很多被不断调节的硬编码延迟值；建议把这些时间参数集中到命名常量或配置结构中，这样可以更容易在一个地方理解和调整整体行为。
- 重复出现的 key_down/key_up 和延迟模式（尤其是在跳跃以及与 F/空格 交互相关的部分）可以重构为一些小的辅助函数，以减少重复代码，并让每段动作序列的意图更清晰。
给 AI Agent 的提示
请根据这次代码评审中的评论进行修改：
## 总体评论
- 这里出现了很多被不断调节的硬编码延迟值；建议把这些时间参数集中到命名常量或配置结构中，这样可以更容易在一个地方理解和调整整体行为。
- 重复出现的 key_down/key_up 和延迟模式（尤其是在跳跃以及与 F/空格 交互相关的部分）可以重构为一些小的辅助函数，以减少重复代码，并让每段动作序列的意图更清晰。帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- There are many hard-coded delay values being tuned here; consider centralizing these timings into named constants or a config structure so the behavior is easier to understand and adjust in one place.
- The repeated key_down/key_up and delay patterns (especially around jumping and interacting with F/space) could be refactored into small helper functions to reduce duplication and make the intent of each action sequence clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are many hard-coded delay values being tuned here; consider centralizing these timings into named constants or a config structure so the behavior is easier to understand and adjust in one place.
- The repeated key_down/key_up and delay patterns (especially around jumping and interacting with F/space) could be refactored into small helper functions to reduce duplication and make the intent of each action sequence clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CCYellowStar2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
调整 PinkPawHeistScheme2Action 的移动和交互时序，以提升抢劫流程的可靠性和流畅度。
Enhancements:
Original summary in English
Summary by Sourcery
Tune PinkPawHeistScheme2Action movement and interaction timings to improve the reliability and smoothness of the heist sequence.
Enhancements: