-
Notifications
You must be signed in to change notification settings - Fork 45
[PT1-97] Fixes after OpenZeppelin audit review #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sunnesoft
commented
Aug 19, 2025
- Added missing Docstrings to Immutables lib.
- Modifier onlyTaker() naming Improvement
- Added Fee Amount check in order creation flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements fixes based on OpenZeppelin audit feedback, focusing on code quality improvements and security enhancements.
- Added comprehensive docstrings to all functions in the ImmutablesLib library
- Renamed modifier from
onlyTakertoonlyCallerfor better semantic clarity - Added fee validation to prevent excessive fees during order creation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/libraries/ImmutablesLib.sol | Added complete docstring documentation for all public functions |
| contracts/BaseEscrow.sol | Renamed modifier from onlyTaker to onlyCaller for improved naming |
| contracts/EscrowSrc.sol | Updated modifier references to use the renamed onlyCaller |
| contracts/EscrowDst.sol | Updated modifier references to use the renamed onlyCaller |
| contracts/BaseEscrowFactory.sol | Added fee amount validation to prevent excessive fees |
| test/integration/EscrowFactory.t.sol | Re-enabled a previously skipped test |
| Makefile | Fixed typo in .PHONY declaration |
| .gas-snapshot | Updated gas consumption values after code changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.