Skip to content

Conversation

@Sunnesoft
Copy link
Contributor

No description provided.

@Sunnesoft Sunnesoft requested review from Copilot and galekseev August 19, 2025 14:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes explicit casting operations when handling fee recipient addresses in the escrow system. The changes simplify the code by removing unnecessary Address.wrap(uint160()) wrapper calls around protocolFeeRecipient and integratorFeeRecipient parameters.

Key changes:

  • Simplified address parameter encoding by removing explicit type casting
  • Updated gas snapshots to reflect the reduced gas consumption from the optimization
  • Fixed a minor formatting issue in the Makefile

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
contracts/BaseEscrowFactory.sol Removed explicit Address.wrap casting for fee recipient parameters in abi.encode
test/utils/libraries/CrossChainTestLib.sol Removed explicit Address.wrap casting for fee recipient parameters in test utilities
.gas-snapshot Updated gas consumption values reflecting the optimization benefits
Makefile Fixed missing dot prefix in .PHONY declaration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@galekseev galekseev merged commit 366f745 into master Oct 8, 2025
5 checks passed
@galekseev galekseev deleted the fix/parameters-encoding branch October 8, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants