chore: release package(s) #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update removes two changeset files and updates changelogs and package versions for Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@1stg/app-config
@1stg/babel-preset
@1stg/browserslist-config
@1stg/commitlint-config
@1stg/common-config
@1stg/config
@1stg/eslint-config
@1stg/markuplint-config
@1stg/nano-staged
@1stg/postcss-config
@1stg/prettier-config
@1stg/remark-preset
@1stg/simple-git-hooks
@1stg/stylelint-config
@1stg/tsconfig
commit: |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e999bec in 41 seconds. Click for details.
- Reviewed
134lines of code in8files - Skipped
1files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/config/CHANGELOG.md:3
- Draft comment:
Changelog entry for v1.2.1 is clear and follows the existing format. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/config/package.json:3
- Draft comment:
Version bump to 1.2.1 and metadata updates (e.g. homepage) look correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/nano-staged/CHANGELOG.md:3
- Draft comment:
Nano-staged changelog for v0.2.2 is properly updated with patch note and dependency list. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. packages/nano-staged/package.json:3
- Draft comment:
Version updated to 0.2.2 and dependency versions are bumped as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. packages/prettier-config/CHANGELOG.md:3
- Draft comment:
Changelog entry for v5.3.1 is clear and documents the dependency bump. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. packages/prettier-config/package.json:3
- Draft comment:
Version bump to 5.3.1 and dependency declarations (including @1stg/config) are correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_5Gy5gxTxSYM49cYZ
You can customize 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 39 39
Lines 278 278
Branches 129 129
======================================
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/nano-staged/CHANGELOG.md (1)
7-12: Nit: duplicate commit hash in changelogThe updated-dependencies bullet lists the same commit hash twice. Not harmful but a quick edit keeps the changelog tidy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (8)
.changeset/proud-clowns-check.md(0 hunks).changeset/thin-dolls-tap.md(0 hunks)packages/config/CHANGELOG.md(1 hunks)packages/config/package.json(1 hunks)packages/nano-staged/CHANGELOG.md(1 hunks)packages/nano-staged/package.json(2 hunks)packages/prettier-config/CHANGELOG.md(1 hunks)packages/prettier-config/package.json(2 hunks)
💤 Files with no reviewable changes (2)
- .changeset/thin-dolls-tap.md
- .changeset/proud-clowns-check.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (4)
packages/config/package.json (1)
3-3: Version bump looks consistentPatch release to 1.2.1 with no other manifest changes – all good.
packages/config/CHANGELOG.md (1)
3-8: Changelog entry present and clearThe 1.2.1 section accurately documents the fix and links the commit. 👍
packages/prettier-config/package.json (1)
3-4: Confirm downstream compatibility with Node >= 18
@1stg/[email protected]still declares"engines": { "node": "^18.18.0 || ^20.9.0 || >=21.1.0" }Any package that depends on it (e.g.
@1stg/nano-staged) should expose a compatibleenginesrange, or consumers on Node 14/16 will hit install warnings/errors.No change needed here, but please verify dependent manifests reflect this.
Also applies to: 30-32
packages/prettier-config/CHANGELOG.md (1)
3-11: Changelog entry looks correct and follows the Changesets formatting conventions. Nothing to adjust.
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
e999bec to
c3bd453
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed c3bd453 in 1 minute and 47 seconds. Click for details.
- Reviewed
232lines of code in13files - Skipped
1files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/config/CHANGELOG.md:7
- Draft comment:
The changelog for @1stg/config shows that version 1.2.0 added '--experimental-cli' support for PRETTIER_EXPERIMENTAL_CLI, but then 1.2.1 fixes it saying the env is already supported by prettier. Consider clarifying the intended behavior to avoid user confusion. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. packages/app-config/package.json:10
- Draft comment:
The node engine requirement is set to '>=18.18'. Verify if this less specific range compared to other packages is intentional for consistency. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. packages/nano-staged/package.json:11
- Draft comment:
The engines field in nano-staged uses a more complex range ('^18.18.0 || ^20.9.0 || >=21.1.0'). Please confirm that this specific range is deliberate and appropriately different from other package engine fields. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. packages/prettier-config/package.json:11
- Draft comment:
The node engines range in prettier-config mirrors that in nano-staged, which appears consistent. No changes required here. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. packages/prettier-config/CHANGELOG.md:9
- Draft comment:
There's a potential typographical issue on this line: the markdown link for the updated dependency seems to have an extra opening bracket ([97cedcc]. Please verify if the double bracket is intended or if one should be removed. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The double bracket format appears to be the standard format used throughout this changelog for dependency updates. The comment suggests changing the established format, which would make this entry inconsistent with all other similar entries. The comment appears to be incorrect about this being a typographical error. Could there be a reason why double brackets are incorrect here that I'm missing? Could this be a new format that should replace the old format? No - the double bracket format is clearly established and consistent throughout the entire changelog history. Changing it would create inconsistency. If the format needed to change, it should be changed everywhere, not just here. The comment should be deleted as it incorrectly suggests changing an established, consistent formatting pattern in the changelog.
Workflow ID: wflow_DucxgkBizQpXjW6l
You can customize
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
c3bd453 to
a3777ea
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed a3777ea in 58 seconds. Click for details.
- Reviewed
232lines of code in13files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/config/CHANGELOG.md:3
- Draft comment:
Changelog for @1stg/config is consistent; note the v1.2.0 experimental CLI change is corrected in v1.2.1. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, providing information about the changelog and a correction in a specific version. It does not offer a suggestion, ask for confirmation, or point out a potential issue in the code.
2. packages/nano-staged/package.json:11
- Draft comment:
Engine and dependency versions in nano-staged are updated consistently (v0.3.0) with correct peer dependency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. packages/prettier-config/package.json:11
- Draft comment:
Prettier-config package updated to v5.3.1 with correct exports and dependency updates (e.g. prettier-plugin-sh v0.18). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_XtlqUTBEYizy0M8O
You can customize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@1stg/[email protected]
Minor Changes
5343736Thanks @JounQin! - fix: clarify correct engines field due to1stg/prettier-configPatch Changes
5343736]:@1stg/[email protected]
Minor Changes
5343736Thanks @JounQin! - fix: clarify correct engines field due to1stg/prettier-configPatch Changes
97cedcc,5343736,97cedcc]:@1stg/[email protected]
Minor Changes
5343736Thanks @JounQin! - fix: clarify correct engines field due to1stg/prettier-configPatch Changes
#386
97cedccThanks @JounQin! - fix:PRETTIER_EXPERIMENTAL_CLIenv is already supported by prettier itselfUpdated dependencies [
97cedcc,97cedcc]:@1stg/[email protected]
Patch Changes
97cedccThanks @JounQin! - fix:PRETTIER_EXPERIMENTAL_CLIenv is already supported by prettier itself@1stg/[email protected]
Patch Changes
#386
97cedccThanks @JounQin! - chore(deps): bumpprettier-plugin-shv0.18Updated dependencies [
97cedcc]:Important
Release multiple packages with version updates, dependency changes, and engine field clarifications.
@1stg/[email protected],@1stg/[email protected],@1stg/[email protected],@1stg/[email protected],@1stg/[email protected].1stg/prettier-configin@1stg/app-config,@1stg/common-config,@1stg/nano-staged.PRETTIER_EXPERIMENTAL_CLIenv is already supported by prettier itself in@1stg/nano-staged,@1stg/config.prettier-plugin-shto v0.18 in@1stg/prettier-config.@1stg/common-confignow depends on@1stg/[email protected],@1stg/[email protected].@1stg/nano-stagednow depends on@1stg/[email protected],@1stg/[email protected].@1stg/prettier-confignow depends on@1stg/[email protected].This description was created by
for a3777ea. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Bug Fixes
PRETTIER_EXPERIMENTAL_CLIenvironment variable, confirming native support in Prettier and removing redundant handling.enginesfield configuration for related packages.Chores