[SYS] Feature/global filter and tests#2252
Open
Odyno wants to merge 1 commit into1technophile:developmentfrom
Open
[SYS] Feature/global filter and tests#2252Odyno wants to merge 1 commit into1technophile:developmentfrom
Odyno wants to merge 1 commit into1technophile:developmentfrom
Conversation
3 tasks
Odyno
force-pushed
the
feature/global-filter-and-tests
branch
4 times, most recently
from
ac808bd to
21dbbce
Compare
- Added Global Filter features - Implemented basic tests - Created test helpers for common testing utilities, including JSON generation and MQTT topic creation. - Developed integration tests for module interactions, MQTT message flow, and configuration management. - Added mock implementations for unit testing, including IStorage and RFBaseGateway. - Introduced Command actions and status returns - Added comprehensive test cases for block and pass list functionalities, including edge cases and ignore flags. - Included wildcard pattern matching tests for both pass and block lists. - Impruved Storage management and logging in core components; add NoopStorage for non-ESP32 targets Refactor logging in Filter and MessageFilter classes; improve message filtering logic in pub function feat: Implement topic filtering functionality in Filter and MessageFilter classes - Added methods to add, remove, and check for topic filters in the Filter class. - Introduced a constant for the topic filter key to optimize memory usage. - Enhanced MessageFilter to handle topic rules from incoming commands. - Implemented logic to check allowed topics based on pass and block lists. - Added comprehensive unit tests for topic filtering, including edge cases and wildcard patterns. - Updated existing tests to ensure compatibility with new filtering logic.
Odyno
force-pushed
the
feature/global-filter-and-tests
branch
from
21dbbce to
883dda8
Compare
3 tasks
Contributor
Author
|
@1technophile How do you prefer that I do the rebase for this branch, which has been here for a while? Should I rebase it on dev, or should I connect it to the proposed workflow? There are many changes going around now, and I don't understand if the delay is a matter of timing or if there is simply no intention (which is totally understandable, I just need to know) to merge it. |
Owner
|
I will test the new workflow in the next days, if I merge it you could rebase this one from dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Test Documentation: https://github.com/Odyno/OpenMQTTGateway/tree/feature/global-filter-and-tests/test
Filter Documentation: https://github.com/Odyno/OpenMQTTGateway/blob/feature/global-filter-and-tests/docs/use/gateway.md#filter-messages
Checklist: