Skip to content

Dont make HADiscovery switch if RF is receive only#772

Merged
1technophile merged 1 commit into1technophile:developmentfrom
jmw6773:RF_NoTrans_NoHADiscovery
Oct 5, 2020
Merged

Dont make HADiscovery switch if RF is receive only#772
1technophile merged 1 commit into1technophile:developmentfrom
jmw6773:RF_NoTrans_NoHADiscovery

Conversation

@jmw6773
Copy link
Contributor

@jmw6773 jmw6773 commented Oct 5, 2020

@1technophile, thought of this while minor tweak while testing the HADiscovery from the previous PR.

If the RFGateway is only used to receive and not to transmit, via RF_DISABLE_TRANSMIT, is there a reason to create a switch in Home Assistant for the received code?

This PR disables creating a HADiscovery switch when the RF_DISABLE_TRANSMIT define is set.
Let me know if you want me to make a note of this in the docs and I'll push an update.

@1technophile 1technophile added this to the v0.9.6 milestone Oct 5, 2020
@1technophile
Copy link
Owner

Hi,

Yes well seen,

Let me know if you want me to make a note of this in the docs and I'll push an update.

I don't think it is necessary

@1technophile 1technophile merged commit 20b728a into 1technophile:development Oct 5, 2020
JeroenWiersma pushed a commit to JeroenWiersma/OpenMQTTGateway that referenced this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants