Skip to content

Minor RTL_433 Tuning#960

Merged
1technophile merged 13 commits into1technophile:developmentfrom
NorthernMan54:development
May 29, 2021
Merged

Minor RTL_433 Tuning#960
1technophile merged 13 commits into1technophile:developmentfrom
NorthernMan54:development

Conversation

@NorthernMan54
Copy link
Collaborator

@NorthernMan54 NorthernMan54 commented May 27, 2021

  • rtl_433 Default to using value as a subject for more robust Mqtt topics
  • rtl_433 Default to not publishing messages for unparsed signals

@NorthernMan54
Copy link
Collaborator Author

NorthernMan54 commented May 27, 2021

Build fail - value as a subject brakes for string not supporting uint64_t, which would have been a latent defect

home/runner/work/OpenMQTTGateway/OpenMQTTGateway/main/main.ino: In function 'void pub(const char*, ArduinoJson::JsonObject&)':
7694
/home/runner/work/OpenMQTTGateway/OpenMQTTGateway/main/main.ino:301:41: error: call of overloaded 'String(uint64_t&)' is ambiguous
7695
topic = topic + "/" + String(value);
7696
^
7697
In file included from /home/runner/.platformio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:146:0,
7698

@1technophile 1technophile added this to the v0.9.7 milestone May 29, 2021
@1technophile
Copy link
Owner

Thanks for the PR

@1technophile 1technophile merged commit 33fa1ca into 1technophile:development May 29, 2021
@NorthernMan54
Copy link
Collaborator Author

Tks

h2zero pushed a commit to h2zero/OpenMQTTGateway that referenced this pull request May 30, 2021
* Update to SmartRC-CC1101-Driver-Lib@^2.5.4 and removal of workaround from 1technophile#847

Tks to @LSatan workaround no longer needed
LSatan/SmartRC-CC1101-Driver-Lib#65

* Default to value as subject for rtl_433 and receiver switching

* Default to not publishing unparsed signals

* Fix for missing String for uint64_t

* Fix is only required when value a subject is defined and not PiLight

Co-authored-by: Northern Man <sgracey@Heisenberg.local>
JeroenWiersma pushed a commit to JeroenWiersma/OpenMQTTGateway that referenced this pull request Oct 18, 2025
* Update to SmartRC-CC1101-Driver-Lib@^2.5.4 and removal of workaround from 1technophile#847

Tks to @LSatan workaround no longer needed
LSatan/SmartRC-CC1101-Driver-Lib#65

* Default to value as subject for rtl_433 and receiver switching

* Default to not publishing unparsed signals

* Fix for missing String for uint64_t

* Fix is only required when value a subject is defined and not PiLight

Co-authored-by: Northern Man <sgracey@Heisenberg.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants