Skip to content

Remove Secure Connection macro and add the config to wifimanager.#961

Merged
h2zero merged 1 commit into1technophile:developmentfrom
h2zero:mqtt-config
Jun 3, 2021
Merged

Remove Secure Connection macro and add the config to wifimanager.#961
h2zero merged 1 commit into1technophile:developmentfrom
h2zero:mqtt-config

Conversation

@h2zero
Copy link
Collaborator

@h2zero h2zero commented May 27, 2021

This adds the ability to specify if the MQTT broker connection is secure via a checkbox on the config page of WiFiManager.
Also added to the WiFiManager config page is a text box to enter the brokers TLS certificate.

In the case of using manual configuration a new macro is created MQTT_SECURE_DEFAULT; when defined as true a secure connection will be requested and the certificate defined in user_config.h will be used.

@1technophile 1technophile added this to the v0.9.7 milestone May 27, 2021
@h2zero
Copy link
Collaborator Author

h2zero commented May 27, 2021

Build fails on env:nodemcuv2-2g

platformio/packages/framework-arduinoespressif8266/tools/sdk/libc/xtensa-lx106-elf/lib/libc.a(lib_a-sscanf.o): in function sscanf': /home/earle/src/esp-quick-toolchain/repo/newlib/newlib/libc/stdio/sscanf.c:411: multiple definition of sscanf'; .pio/build/nodemcuv2-2g/lib621/libA6lib.a(sscanf.cpp.o):sscanf.cpp:(.text.sscanf+0x4): first defined here

Cause is the A6lib sscanf.cpp is redefining newlib functions. Seems that the file could be removed from the lib as that was included before newlib was in the 8266 framework I believe.

@h2zero h2zero force-pushed the mqtt-config branch 2 times, most recently from 53c64f9 to 2bc9b42 Compare May 28, 2021 03:36
@1technophile
Copy link
Owner

1technophile commented May 28, 2021

Cause is the A6lib sscanf.cpp is redefining newlib functions. Seems that the file could be removed from the lib as that was included before newlib was in the 8266 framework I believe.

I would suggest to fork it, modify and point to the fork temporarily.
You may submit a PR to the A6lib repo.

@h2zero h2zero force-pushed the mqtt-config branch 2 times, most recently from 387cc56 to 5f858e8 Compare May 29, 2021 04:12
@h2zero
Copy link
Collaborator Author

h2zero commented May 29, 2021

Cause is the A6lib sscanf.cpp is redefining newlib functions. Seems that the file could be removed from the lib as that was included before newlib was in the 8266 framework I believe.

I would suggest to fork it, modify and point to the fork temporarily.
You may submit a PR to the A6lib repo.

done

@h2zero h2zero force-pushed the mqtt-config branch 4 times, most recently from a628b22 to b39aa6d Compare June 3, 2021 00:16
@h2zero h2zero marked this pull request as ready for review June 3, 2021 00:19
This adds the ability to specify if the MQTT broker connection is secure via a checkbox on the config page of WiFiManager.
Also added to the WiFiManager config page is a text box to enter the brokers TLS certificate.

In the case of using manual configuration a new macro is created MQTT_SECURE_DEFAULT.
When defined as true a secure connection will be requested and the certificate defined in user_config.h will be used.
@h2zero h2zero merged commit 31efcb3 into 1technophile:development Jun 3, 2021
@h2zero h2zero deleted the mqtt-config branch June 4, 2021 04:06
JeroenWiersma pushed a commit to JeroenWiersma/OpenMQTTGateway that referenced this pull request Oct 18, 2025
…echnophile#961)

This adds the ability to specify if the MQTT broker connection is secure via a checkbox on the config page of WiFiManager.
Also added to the WiFiManager config page is a text box to enter the brokers TLS certificate.

In the case of using manual configuration a new macro is created MQTT_SECURE_DEFAULT.
When defined as true a secure connection will be requested and the certificate defined in user_config.h will be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants