Fix BME280

[spacemanspiff2007]

Fix log output, since %H never prints anything

[spacemanspiff2007]

#963

[spacemanspiff2007]

Initialized BME280, otherwise it will not work

[spacemanspiff2007]

I've updated the files so lint should pass now.
The other check seems to fail because of some unrelated reason but I am not sure.

[h2zero]

Build error notes:

error: no matching function for call to 'TwoWire::begin(int&, int&)'
framework-arduino-avr\libraries\Wire\src/Wire.h:53:10: note: candidate: void TwoWire::begin()
framework-arduino-avr\libraries\Wire\src/Wire.h:54:10: note: candidate: void TwoWire::begin(uint8_t)
framework-arduino-avr\libraries\Wire\src/Wire.h:55:10: note: candidate: void TwoWire::begin(int)

AVR wire library does not accept pins for parameters in the call to begin()

I recommend using a conditional check such as:

#Ifdef ESP32
  Wire.setPins(BME280_PIN_SDA, BME280_PIN_SCL);
#endif

Instead of the Wire.begin call that was added.

[spacemanspiff2007]

@h2zero
Thank you for your quick analysis! Do you think it makes sense to just disable this for the AVRs?
I think the esp8266 supports it, too.
What would be the def for that?

[h2zero]

@spacemanspiff2007

Do you think it makes sense to just disable this for the AVRs?
I think the esp8266 supports it, too.
What would be the def for that?

I do not have the means to test the functionality but you could add the check as:

#if defined (ESP8266) || defined(ESP32)
  Wire.setPins(BME280_PIN_SDA, BME280_PIN_SCL);
#endif

That should at least compile and I don't see any reason for it to affect the function of all involved.

[spacemanspiff2007]

I've done exactly that!
Thank you very much for you help!

[h2zero]

No worries 😄 lets hope it works out.

[h2zero]

@spacemanspiff2007, sorry I guess 8266 does not have setPins().

You'll need to change the check to this:

#  if defined(ESP8266) || defined(ESP32)
  Wire.begin(BME280_PIN_SDA, BME280_PIN_SCL);
#  else
  Wire.begin();
#  endif

[1technophile]

Thanks for the PR, for the code format you can take a look below:
So as to format automaticaly your document you have to add the "clang-Format" extension to VSCode, once done, you can format the code by doing a right click into the code file window and clicking "Format document".

[spacemanspiff2007]

@1technophile
Thanks for the hint - I'll do this the next time from the beginning.